fix(zone.js): correctly patch es6 classes#15
Merged
NathanWalker merged 1 commit intomainfrom Jul 21, 2021
Merged
Conversation
NathanWalker
approved these changes
Jul 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Zone uses a
for(prop in object)to patch all class properties, but this doesn't work with es6 as class properties aren't enumerable. Since NativeScript is distributed in es6+ the FileReader polyfill doesn't get properly patched by zonejsWhat is the new behavior?
Use
Object.getOwnPropertyNamesinstead, so FileReader is patched correctly.Currently only MutationObserver, WebKitMutationObserver, IntersectionObserver, FileReader and legacy XMLHttpRequest are patched this way. Of all of them, only FileReader is polyfilled by NativeScript (the legacy XMLHttpRequest patch is already disabled)
Fixes #14.