From acd25d7310a52fd52b3991ea774385df2c095d19 Mon Sep 17 00:00:00 2001
From: Eduardo Speroni <edusperoni@gmail.com>
Date: Mon, 5 Jul 2021 20:22:01 -0300
Subject: [PATCH] fix(list-view): always set a default template

Also logs when we try to create a view without a valid template key
---
 .../src/lib/cdk/list-view/list-view.component.ts   | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/packages/angular/src/lib/cdk/list-view/list-view.component.ts b/packages/angular/src/lib/cdk/list-view/list-view.component.ts
index 8b350ac..f8b0980 100644
--- a/packages/angular/src/lib/cdk/list-view/list-view.component.ts
+++ b/packages/angular/src/lib/cdk/list-view/list-view.component.ts
@@ -147,15 +147,15 @@ export class ListViewComponent<T = any> implements DoCheck, OnDestroy, AfterCont
     // The itemTemplateQuery may be changed after list items are added that contain <template> inside,
     // so cache and use only the original template to avoid errors.
     this.fallbackItemTemplate = this.itemTemplateQuery;
-    if (this._templateMap) {
-      // sometimes templates are registered before loader is ready, so we update here
-      this._templateMap.forEach((t) => (t.location = this.loader));
-    } else if (this.fallbackItemTemplate) {
+    if (this.fallbackItemTemplate && !this._templateMap?.has('default')) {
       // apparently you can create a Core ListView without a template...
+      // we also add a fallback default for when the user sets multiple templates but no templateSelector
       this.registerTemplate('default', this.fallbackItemTemplate);
     }
 
     if (this._templateMap) {
+      // sometimes templates are registered before loader is ready, so we update here
+      this._templateMap.forEach((t) => (t.location = this.loader));
       if (NativeScriptDebug.isLogEnabled()) {
         NativeScriptDebug.listViewLog('Setting templates');
       }
@@ -219,6 +219,12 @@ export class ListViewComponent<T = any> implements DoCheck, OnDestroy, AfterCont
       // this should never enter if it creates the view
       const templateKey = typeof lview.itemTemplateSelector === 'function' ? lview.itemTemplateSelector(currentItem, index, items) : 'default';
       template = this._templateMap.get(templateKey);
+      if (!template) {
+        if (NativeScriptDebug.isLogEnabled()) {
+          NativeScriptDebug.listViewError(`Template for key '${templateKey}' not found.`);
+        }
+        return;
+      }
       args.view = template.create({ index, data: currentItem });
     }
     this.setupViewRef(template.getEmbeddedViewRef(args.view), currentItem, index, args.view);