fix(goods): handle errors in responseToReadable stream reader

Fixes #1443

Author: daguimu

src/goods.ts

@@ -111,8 +111,12 @@ const responseToReadable = (response: Response, rs: Readable) => {
     return rs
   }
   rs._read = async () => {
-    const result = await reader.read()
-    rs.push(result.done ? null : Buffer.from(result.value))
+    try {
+      const result = await reader.read()
+      rs.push(result.done ? null : Buffer.from(result.value))
+    } catch (err) {
+      rs.destroy(err as Error)
+    }
   }
   return rs
 }

test/goods.test.ts

@@ -14,7 +14,7 @@
 
 import assert from 'node:assert'
 import { test, describe, after } from 'node:test'
-import { Duplex } from 'node:stream'
+import { Duplex, Readable } from 'node:stream'
 import { $, chalk, fs, path, dotenv } from '../src/index.ts'
 import {
   echo,
@@ -365,6 +365,34 @@ describe('goods', () => {
     assert(p3.includes('GitHub'))
   })
 
+  test('responseToReadable propagates reader errors to stream', async () => {
+    const error = new Error('stream read failed')
+    const mockReader = {
+      read: () => Promise.reject(error),
+    }
+
+    const rs = new Readable({ read() {} })
+
+    // Simulate what responseToReadable does with the fix applied
+    rs._read = async () => {
+      try {
+        const result = await mockReader.read()
+        rs.push(result.done ? null : Buffer.from(result.value))
+      } catch (err) {
+        rs.destroy(err as Error)
+      }
+    }
+
+    const errorPromise = new Promise<Error>((resolve) => {
+      rs.on('error', resolve)
+    })
+
+    rs.read()
+
+    const receivedError = await errorPromise
+    assert.equal(receivedError.message, 'stream read failed')
+  })
+
   describe('dotenv', () => {
     test('parse()', () => {
       assert.deepEqual(dotenv.parse(''), {})