-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Edit status page regression in 2.1Β #6935
Description
π I have found these related issues/pull requests
Possibly related to #6888
π‘οΈ Security Policy
- I have read and agree to Uptime Kuma's Security Policy.
π Description
In 2.0, clicking save when editing a status page correctly closed the settings sidebar and applied your settings.
As of 2.1.0-beta.0 (up to and including 2.1.1), clicking save disables the save button permanently, with further changes to the settings not re-enabling the button. Further, when a high number of monitors (>50) are added to the page, the page spikes to 100% CPU usage, causing changes to sometimes not even be saved.
Looking at websocket messages, I see a high number of messages come in specifically when editing the page:
https://github.com/user-attachments/assets/070b58bc-5620-4558-bac5-a9d77ea6dcdb
After hogging the CPU for a little while, I get a bunch of repeated errors logged in console, but they're difficult to make sense of without source maps. Will try to run from source later.
π Reproduction steps
- Add 50+ monitors to a status page
- Edit status page
- Click Save
- Attempt to make further edit
π Expected behavior
- Page settings get closed on first Save click
- Changes get reliably saved
- CPU usage does not spike
π Actual Behavior
As described above.
π» Uptime-Kuma Version
2.1.1
π» Operating System and Arch
Docker
π Browser
Google Chrome 144.0.7559.132
π₯οΈ Deployment Environment
Docker