Skip to content

Commit 0682367

Browse files
committed
Run eslint during pretest, fix existing eslint findings
1 parent 5ecda3a commit 0682367

File tree

8 files changed

+15
-14
lines changed

8 files changed

+15
-14
lines changed

bench/glob-parent.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
const { Suite } = require('benchmark');
4-
const { cyan, red, green } = require('ansi-colors');
4+
const { red } = require('ansi-colors');
55
const argv = require('minimist')(process.argv.slice(2));
66
const parent = require('glob-parent');
77
const scan = require('../lib/scan');
@@ -11,7 +11,7 @@ const scan = require('../lib/scan');
1111
*/
1212

1313
const cycle = (e, newline) => {
14-
process.stdout.write(`\u001b[G ${e.target}${newline ? `\n` : ''}`);
14+
process.stdout.write(`\u001b[G ${e.target}${newline ? '\n' : ''}`);
1515
};
1616

1717
function bench(name, options) {

bench/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
const { Suite } = require('benchmark');
4-
const { cyan, red, green } = require('ansi-colors');
4+
const { red } = require('ansi-colors');
55
const argv = require('minimist')(process.argv.slice(2));
66
const mm = require('../node_modules/minimatch');
77
const pm = require('..');
@@ -11,7 +11,7 @@ const pm = require('..');
1111
*/
1212

1313
const cycle = (e, newline) => {
14-
process.stdout.write(`\u001b[G ${e.target}${newline ? `\n` : ''}`);
14+
process.stdout.write(`\u001b[G ${e.target}${newline ? '\n' : ''}`);
1515
};
1616

1717
const bench = (name, options) => {

examples/extglob.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
const pm = require('..');
22

3-
43
console.log(pm.makeRe('(a|b|c)'));
54
console.log(pm.makeRe('!(a|b|c)'));
65
console.log(pm.makeRe('*(a|b|c)'));

examples/match.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
const path = require('path');
4-
const assert = require('assert');
4+
// const assert = require('assert');
55
const pm = require('..');
66

77
/**

examples/option-expandRange.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ const regex = pm.makeRe('foo/{01..25}/bar', {
1111
console.log(regex);
1212
//=> /^(?:foo\/((?:0[1-9]|1[0-9]|2[0-5]))\/bar)$/
1313

14-
console.log(regex.test('foo/00/bar')) // false
15-
console.log(regex.test('foo/01/bar')) // true
16-
console.log(regex.test('foo/10/bar')) // true
17-
console.log(regex.test('foo/22/bar')) // true
18-
console.log(regex.test('foo/25/bar')) // true
19-
console.log(regex.test('foo/26/bar')) // false
14+
console.log(regex.test('foo/00/bar')); // false
15+
console.log(regex.test('foo/01/bar')); // true
16+
console.log(regex.test('foo/10/bar')); // true
17+
console.log(regex.test('foo/22/bar')); // true
18+
console.log(regex.test('foo/25/bar')); // true
19+
console.log(regex.test('foo/26/bar')); // false

lib/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ exports.removeBackslashes = str => {
1616
return str.replace(REGEX_REMOVE_BACKSLASH, match => {
1717
return match === '\\' ? '' : match;
1818
});
19-
}
19+
};
2020

2121
exports.supportsLookbehinds = () => {
2222
const segs = process.version.slice(1).split('.');

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,12 @@
1818
"node": ">=8"
1919
},
2020
"scripts": {
21+
"pretest": "eslint .",
2122
"test": "mocha",
2223
"cover": "nyc --reporter=text --reporter=html mocha"
2324
},
2425
"devDependencies": {
26+
"eslint": "^6.4.0",
2527
"fill-range": "^7.0.1",
2628
"gulp-format-md": "^2.0.0",
2729
"mocha": "^6.0.2",

test/globstars.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
require('mocha');
44
const assert = require('assert').strict;
55
const match = require('./support/match');
6-
const { isMatch, makeRe } = require('..');
6+
const { isMatch } = require('..');
77

88
describe('stars', () => {
99
describe('issue related', () => {

0 commit comments

Comments
 (0)