Skip to content

Drop multi-root workspace and dev container support#14870

Merged
brettcannon merged 2 commits intomicrosoft:mainfrom
brettcannon:lessen-prompts
Dec 3, 2020
Merged

Drop multi-root workspace and dev container support#14870
brettcannon merged 2 commits intomicrosoft:mainfrom
brettcannon:lessen-prompts

Conversation

@brettcannon
Copy link
Copy Markdown
Member

@brettcannon brettcannon commented Dec 3, 2020

No one was using either, so they were doing nothing but creating prompts that everyone kept dimissing.

Turns out no one was using them, thus the prompts were simply noise.
@brettcannon brettcannon added the no-changelog No news entry required label Dec 3, 2020
Copy link
Copy Markdown

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

Copy link
Copy Markdown

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the references to pvsc.code-workspace and .devcontainer/** in .vscodeignore as well please?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 3, 2020

Codecov Report

Merging #14870 (e87c23a) into main (43d3f8e) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #14870   +/-   ##
======================================
  Coverage     65%      65%           
======================================
  Files        551      551           
  Lines      25889    25889           
  Branches    3672     3672           
======================================
  Hits       16902    16902           
  Misses      8294     8294           
  Partials     693      693           
Impacted Files Coverage Δ
...ent/pythonEnvironments/discovery/locators/index.ts 84% <0%> (-1%) ⬇️
src/client/common/featureDeprecationManager.ts 40% <0%> (ø)
...nt/testing/common/services/discoveredTestParser.ts 15% <0%> (ø)
src/client/telemetry/importTracker.ts 20% <0%> (+1%) ⬆️

@brettcannon
Copy link
Copy Markdown
Member Author

@kimadeline I just did a clean up of .vscodeignore; PTAL.

@brettcannon brettcannon merged commit 0995e3b into microsoft:main Dec 3, 2020
@brettcannon brettcannon deleted the lessen-prompts branch December 3, 2020 17:37
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65%. Comparing base (43d3f8e) to head (e87c23a).
⚠️ Report is 2720 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #14870   +/-   ##
======================================
  Coverage     65%      65%           
======================================
  Files        551      551           
  Lines      25889    25889           
  Branches    3672     3672           
======================================
  Hits       16902    16902           
  Misses      8294     8294           
  Partials     693      693           

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants