Drop multi-root workspace and dev container support#14870
Merged
brettcannon merged 2 commits intomicrosoft:mainfrom Dec 3, 2020
Merged
Drop multi-root workspace and dev container support#14870brettcannon merged 2 commits intomicrosoft:mainfrom
brettcannon merged 2 commits intomicrosoft:mainfrom
Conversation
Turns out no one was using them, thus the prompts were simply noise.
kimadeline
approved these changes
Dec 3, 2020
kimadeline
left a comment
There was a problem hiding this comment.
Can you remove the references to pvsc.code-workspace and .devcontainer/** in .vscodeignore as well please?
Codecov Report
@@ Coverage Diff @@
## main #14870 +/- ##
======================================
Coverage 65% 65%
======================================
Files 551 551
Lines 25889 25889
Branches 3672 3672
======================================
Hits 16902 16902
Misses 8294 8294
Partials 693 693
|
Member
Author
|
@kimadeline I just did a clean up of |
kimadeline
approved these changes
Dec 3, 2020
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14870 +/- ##
======================================
Coverage 65% 65%
======================================
Files 551 551
Lines 25889 25889
Branches 3672 3672
======================================
Hits 16902 16902
Misses 8294 8294
Partials 693 693 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No one was using either, so they were doing nothing but creating prompts that everyone kept dimissing.