Skip to content

Add OSOP workflow example — background job pipeline in portable format#3314

Closed
Archie0125 wants to merge 1 commit intotriggerdotdev:mainfrom
Archie0125:add-osop-example
Closed

Add OSOP workflow example — background job pipeline in portable format#3314
Archie0125 wants to merge 1 commit intotriggerdotdev:mainfrom
Archie0125:add-osop-example

Conversation

@Archie0125
Copy link
Copy Markdown

Summary

  • Adds an OSOP (Open Standard for Orchestration Protocols) workflow example under examples/osop/
  • The example models a typical background job pipeline: receive job request, validate input, AI processing with timeout and retry, store results, webhook callback, and cleanup
  • Includes a README explaining the OSOP format and how to validate/visualize the workflow

What is OSOP?

OSOP is a portable YAML-based workflow standard — think "OpenAPI for workflows." It lets you describe multi-step processes (including background jobs and event-driven pipelines) in a tool-agnostic format that any orchestration engine can read.

Why this PR?

This is a non-invasive, additive-only contribution. The .osop file provides a portable representation of a Trigger.dev-style background job pipeline that can be shared, diffed, and rendered by any OSOP-compatible tool — useful for documentation, onboarding, and cross-tool interoperability.

No existing files are modified.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 2, 2026

⚠️ No Changeset found

Latest commit: f81fa47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Hi @Archie0125, thanks for your interest in contributing!

This project requires that pull request authors are vouched, and you are not in the list of vouched users.

This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details.

@github-actions github-actions bot closed this Apr 2, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f57c6bae-cef4-4073-9b07-a3ef6e819b88

📥 Commits

Reviewing files that changed from the base of the PR and between 0e14b6d and f81fa47.

📒 Files selected for processing (2)
  • examples/osop/README.md
  • examples/osop/background-job-pipeline.osop

Walkthrough

The PR adds two new files to the examples/osop/ directory that document and demonstrate an OSOP (YAML-based, tool-agnostic orchestration workflow standard) implementation for Trigger.dev. A README file explains the OSOP standard's key properties (portability, version control, vendor lock-in prevention) and provides usage instructions. An accompanying OSOP pipeline definition file specifies a background job workflow with six sequential nodes—job intake, input validation, AI processing (using OpenAI's gpt-4o model with a 300-second timeout), result storage, webhook callback, and cleanup—plus a fallback retry edge from the AI processor back to job intake on failure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

Open in Devin Review

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 New examples/ directory deviates from established references/ convention

The repository's documented layout (AGENTS.md, CLAUDE.md, references/README.md) uses references/ for example projects. This PR introduces a new top-level examples/ directory which has no precedent in the repo. While none of the rule files explicitly forbid other directories, the OSOP files don't integrate with the Trigger.dev SDK or platform in any way — they're purely promotional for an external specification. The PR adds no actual Trigger.dev task code, no package.json, and no connection to the monorepo's build system. A reviewer should consider whether this content belongs in the repository at all.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +58 to +61
- from: process-ai
to: receive-job
mode: fallback
label: Retry on failure
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Fallback edge targets receive-job instead of process-ai, restarting the entire pipeline instead of retrying the failed step

The fallback edge on lines 58-61 labeled "Retry on failure" routes from process-ai back to receive-job (the first node in the pipeline). This means an AI processing failure would restart the entire workflow from job submission, rather than retrying just the AI processing step. The intent expressed by the label is to retry the failed operation, so the to: target should be process-ai (to retry the same step) or at most validate-input, not receive-job.

Suggested change
- from: process-ai
to: receive-job
mode: fallback
label: Retry on failure
- from: process-ai
to: process-ai
mode: fallback
label: Retry on failure
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +1 to +36
# OSOP Workflow Example — Trigger.dev Background Job Pipeline

This directory contains a portable workflow definition for a **background job pipeline** pattern, written in [OSOP](https://github.com/osop-org/osop-spec) format.

## What is OSOP?

**OSOP** (Open Standard for Orchestration Protocols) is a YAML-based workflow standard that describes multi-step processes — including background jobs, event-driven pipelines, and AI agent workflows — in a portable, tool-agnostic format. Think of it as "OpenAPI for workflows."

- Any tool can read and render an `.osop` file
- Workflows become shareable, diffable, and version-controllable
- No vendor lock-in: the same workflow runs across different orchestration engines

## Files

| File | Description |
|------|-------------|
| `background-job-pipeline.osop` | Long-running background job: receive request, validate, AI processing with retry, store results, webhook callback, and cleanup |

## How to use

You can read the `.osop` file as plain YAML. To validate or visualize it:

```bash
# Validate the workflow
pip install osop
osop validate background-job-pipeline.osop

# Generate a visual report
npx osop-report background-job-pipeline.osop -o report.html
```

## Learn more

- [OSOP Spec](https://github.com/osop-org/osop-spec) — Full specification
- [OSOP Examples](https://github.com/osop-org/osop-examples) — 30+ workflow templates
- [Trigger.dev Documentation](https://trigger.dev/docs) — Trigger.dev platform docs
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 PR appears to be promotional content for an external "OSOP" specification

Both files exclusively promote "OSOP" (Open Standard for Orchestration Protocols) with links to github.com/osop-org/osop-spec and github.com/osop-org/osop-examples, plus instructions to install osop via pip and osop-report via npx. The content provides no integration with Trigger.dev's SDK, CLI, or platform — it's a standalone YAML file with a README pointing to external tooling. This pattern is consistent with promotional PRs that add third-party specification examples to popular repositories for visibility. A maintainer should verify whether this was requested or coordinated.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant