Skip to content

fix: preserve command output on Windows#4974

Open
MobiusL00p wants to merge 1 commit intoAider-AI:mainfrom
MobiusL00p:fix-run-cmd-windows-output
Open

fix: preserve command output on Windows#4974
MobiusL00p wants to merge 1 commit intoAider-AI:mainfrom
MobiusL00p:fix-run-cmd-windows-output

Conversation

@MobiusL00p
Copy link
Copy Markdown

@MobiusL00p MobiusL00p commented Mar 31, 2026

Summary

  • remove the Windows PowerShell wrapper in run_cmd_subprocess so shell commands keep the default Windows shell=True behavior
  • add a regression test covering the PowerShell-parent path for commands containing commas
  • keep the fix scoped to the Windows run_cmd output regression without changing the pagerank PR

Verification

  • python -m pytest -q tests/basic/test_run_cmd.py
  • python -c "from aider.run_cmd import run_cmd; code, out = run_cmd('echo Hello, World!'); print('EXIT=', code); print('OUT=', repr(out))"
  • python -c "from aider.run_cmd import run_cmd_subprocess; import aider.run_cmd as rc; rc.platform.system=lambda:'Windows'; rc.get_windows_parent_process_name=lambda:'powershell.exe'; code, out = run_cmd_subprocess('echo Hello, World!'); print('EXIT=', code); print('OUT=', repr(out))"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant