Skip to content

Chore: down level logging of individual files operations for s3#140

Merged
ligangty merged 1 commit intoCommonjava:mainfrom
ligangty:main
Mar 1, 2022
Merged

Chore: down level logging of individual files operations for s3#140
ligangty merged 1 commit intoCommonjava:mainfrom
ligangty:main

Conversation

@ligangty
Copy link
Copy Markdown
Member

@ligangty ligangty commented Mar 1, 2022 •
edited
Loading

And also added a new logger to record the progress of files operated every 1000 count.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 1, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1915016723

  • 18 of 25 (72.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 79.04%
Changes Missing Coverage Covered Lines Changed/Added Lines %
charon/storage.py 18 25 72.0%
Files with Coverage Reduction New Missed Lines %
charon/storage.py 3 81.45%
Totals Coverage Status
Change from base Build 1897220931: 0.04%
Covered Lines: 1399
Relevant Lines: 1770
💛 - Coveralls

@ligangty ligangty requested a review from yma955 March 1, 2022 08:46
yma955
yma955 approved these changes Mar 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@yma955 yma955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ligangty ligangty merged commit 3810d11 into Commonjava:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yma955 yma955 yma955 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ligangty @coveralls @yma955