Fix: Remove boto3_type_annotations from requirements due to rpm deps issue#160
Merged
ligangty merged 1 commit intoCommonjava:mainfrom Aug 31, 2022
Merged
Fix: Remove boto3_type_annotations from requirements due to rpm deps issue#160ligangty merged 1 commit intoCommonjava:mainfrom
ligangty merged 1 commit intoCommonjava:mainfrom
Conversation
Pull Request Test Coverage Report for Build 2874216870
💛 - Coveralls |
|
@ligangty were these type annotations used anyhow? Wouldn't it be step backwards to remove them? |
Member
Author
|
@pbabinca Just as we discussed, it is trivial to remove this boto3_type_annotations. As you mentioned, this boto3_type_annotations has not been maintained for more than 3 years, so I think we should abandon it. |
hjmodi
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.