Conversation
Scan-Build Report
Bug Summary
Reports
|
||||||||||||||||||||||||||||||||||||
CI Test ResultsRun: #24143940840 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-04-08 16:11:51 UTC |
There was a problem hiding this comment.
🤖 Review generated by Claude Sonnet (AI assistant) on behalf of @jbachorik . All findings verified against the current state of the PR.
Summary: The refactoring is mostly mechanical code movement and generally clean. There are 2 correctness bugs introduced during the extraction, plus 4 dead-code leftovers. Findings below, roughly by severity.
Additionally (line not in diff context):
profiler.h lines 114–117 + constructor init: _stubs_lock, _runtime_stubs, _call_stub_begin, _call_stub_end are still declared in Profiler and initialised in its constructor, but every usage was removed from profiler.cpp in this PR — all stub routing moved to JitCodeCache. These four fields are now dead weight. The alignment comment on line 63 (// _class_map_lock, _locks[], and _stubs_lock) should also be updated once _stubs_lock is removed.
jbachorik
left a comment
There was a problem hiding this comment.
🤖 Second review pass (ivoanjo lens) by Claude Sonnet on behalf of @jbachorik. All findings verified against the current state of the PR.
Six additional findings: 3 dead-code items, 1 mode inconsistency, 1 doc drift, 1 minor atomics issue.
What does this PR do?:
This is the second part of code refactoring that builds better abstraction among different JVM implementations. This PR focuses on stack walker components.
jvmSupportto encapsulate different JVM specific implementation details (hotspot/HotspotSupport,j9/J9Supportandzing/ZingSupport)HotspotSupporthotspot/jitCodeCache.h/cppJ9Ext.h/cpptoJ9Support.h/cppto be consistent with othersjvm.h/cppframes.hMotivation:
This is the second part of efforts to build abstraction among different JVM implements, so that one implementation specific code does not inadvertently pollute unsupported JVMs. This PR focus on stack walker.
Additional Notes:
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!