Create better service name template in app.yaml#1021
Create better service name template in app.yaml#1021inklesspen wants to merge 1 commit intoGoogleCloudPlatform:masterfrom inklesspen:patch-1
Conversation
Endpoints Frameworks apps on GAE standard must use the appspot.com domain name; users will have to change the line anyway, but this way fewer changes are required.
googlebot
added
the
cla: yes
|
@saicheems @bradfriedman @sepehre can one of you take a look at this? |
|
Why was this closed? |
|
Lack of response from reviewers that own this, if you think this is still a good change I can re-open. @p-buse WDYT? |
|
Brad and Sep are both no longer on the team; perhaps some other reviewers
are available?
…On Tue, Sep 19, 2017 at 10:44 AM, Jon Wayne Parrott < ***@***.***> wrote:
Lack of response from reviewers that own this, if you think this is still
a good change I can re-open. @p-buse <https://github.com/p-buse> WDYT?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1021 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAshXp2BBbEudU67Gx4DPiwI3LZJmTBks5sj_1MgaJpZM4OY2NO>
.
|
|
Got any recommendations? I would very much prefer at least one reviewer from the endpoints team. |
|
tangiel and kryzthov are both on the team. |
|
@tangiel @kryzthov can you take a look? @inklesspen - your GitHub profile doesn't help, are you on the endpoints team as well? |
|
Yes, thanks for doing that. LGTM |
|
@inklesspen Could we also update the README.md file with the same service name pattern? |
|
@jonparrott yes, I am on the endpoints team maintaining Endpoints Frameworks for Python. |
|
@inklesspen cool! this is important for me to know! Let me know when the readme is updated and I'll be happy to merge. |
|
@jonparrott I've updated it, but this PR doesn't seem to have picked things up (possibly because it's closed). |
|
Aw, can you submit a new one? |
4 participants
Endpoints Frameworks apps on GAE standard must use the appspot.com domain name; users will have to change the line anyway, but this way fewer changes are required.