Skip to content

Hackathon/Codelab vision sample#788

Merged
theacodes merged 18 commits intomasterfrom
hackathon-vision-sample
Feb 17, 2017
Merged

Hackathon/Codelab vision sample#788
theacodes merged 18 commits intomasterfrom
hackathon-vision-sample

Conversation

@ryanmats
Copy link
Copy Markdown
Contributor

@ryanmats ryanmats commented Feb 8, 2017

A work in progress for EDU hackathons / Codelab.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2017
@ryanmats
Copy link
Copy Markdown
Contributor Author

Still TODO: use Jinja2 for HTML output, README instructions

@ryanmats ryanmats requested a review from theacodes February 14, 2017 02:38
@ryanmats ryanmats changed the title Hackathon vision sample Hackathon/Codelab vision sample Feb 14, 2017
Copy link
Copy Markdown
Contributor

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests?

@@ -0,0 +1,127 @@
# Copyright 2015 Google Inc. All Rights Reserved.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017?

from google.cloud import vision


CLOUD_STORAGE_BUCKET = '<your-storage-bucket>'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use os.environ and env_variables in app.yaml? (or do you have a good reason for this?)

@ryanmats
Copy link
Copy Markdown
Contributor Author

will add test(s) soon

@theacodes
Copy link
Copy Markdown
Contributor

@ryanmats this looks good, I'd just prefer we put it under /codelabs/flex_and_vision or similar.

@theacodes
Copy link
Copy Markdown
Contributor

Please create a bug for yourself to add tests.

@theacodes theacodes merged commit 26eb8ce into master Feb 17, 2017
@theacodes theacodes deleted the hackathon-vision-sample branch February 17, 2017 21:56
chalmerlowe pushed a commit that referenced this pull request Apr 7, 2026
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants