Skip to content

Debounce rapid file changes#1005

Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot:fix-1004
Sep 24, 2018
Merged

Debounce rapid file changes#1005
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot:fix-1004

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Sep 21, 2018

Fixes #1004

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 21, 2018

Codecov Report

Merging #1005 into master will increase coverage by 0.1%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1005     +/-   ##
=========================================
+ Coverage   39.84%   39.94%   +0.1%     
=========================================
  Files          70       70             
  Lines        3067     3074      +7     
=========================================
+ Hits         1222     1228      +6     
- Misses       1719     1720      +1     
  Partials      126      126
Impacted Files Coverage Δ
pkg/skaffold/config/options.go 81.81% <ø> (ø) ⬆️
cmd/skaffold/app/cmd/cmd.go 0% <0%> (ø) ⬆️
pkg/skaffold/runner/runner.go 54.87% <100%> (+0.23%) ⬆️
pkg/skaffold/watch/watch.go 83.78% <100%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba8da2...6543199. Read the comment docs.

func AddDevFlags(cmd *cobra.Command) {
cmd.Flags().BoolVar(&opts.Cleanup, "cleanup", true, "Delete deployments after dev mode is interrupted")
cmd.Flags().StringArrayVarP(&opts.Watch, "watch-image", "w", nil, "Choose which artifacts to watch. Artifacts with image names that contain the expression will be watched only. Default is to watch sources for all artifacts.")
cmd.Flags().IntVarP(&opts.WatchPollIntervall, "watch-poll-interval", "i", 1000, "Interval (in ms) between two checks for file changes.")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: WatchPollInteral

Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#1004

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit c7ff9d7 into GoogleContainerTools:master Sep 24, 2018
@dgageot dgageot deleted the fix-1004 branch December 28, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants