Examples versioning#1019
Merged
r2d4 merged 5 commits intoGoogleContainerTools:masterfrom Sep 25, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1019 +/- ##
=======================================
Coverage 39.98% 39.98%
=======================================
Files 70 70
Lines 3079 3079
=======================================
Hits 1231 1231
Misses 1721 1721
Partials 127 127Continue to review full report at Codecov.
|
nkubala
approved these changes
Sep 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #367
Fixes #1003
The examples are currently integration tested, but against the code at skaffold HEAD. Configuration changes, such as v1alpha2 -> v1alpha3 will be present at HEAD, but not in the latest released version.
When users download the latest skaffold release, the examples are written for v1alpha3, but the latest release only targets v1alpha2 and below. Therefore, the examples will all fail, and users won't be able to skaffold fix, because the old version does not know about the new transformations. (skaffold fix only helps the situation of
old config, new skaffold, where this isnew config, old skaffold.We would like to keep our examples integration tested, so that they don't break for users. This PR makes
integration/examplesthe canonical example repository. All changes are synced toexampleson each release.This solves:
examples/directory are runnable with the latest released version of skaffoldThis adds the sync to
release_note.shscript, which might not be the best place for it.