Fix issues with build args replacement#1028
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Sep 27, 2018
Merged
Fix issues with build args replacement#1028dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Fixes GoogleContainerTools#1025 Fixes GoogleContainerTools#1024 and other issues… Signed-off-by: David Gageot <david@gageot.net>
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
==========================================
+ Coverage 39.98% 40.13% +0.15%
==========================================
Files 70 70
Lines 3079 3077 -2
==========================================
+ Hits 1231 1235 +4
+ Misses 1721 1718 -3
+ Partials 127 124 -3
Continue to review full report at Codecov.
|
nkubala
approved these changes
Sep 26, 2018
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
Nice, this looks much better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1025
Fixes #1024
and other issues…
Signed-off-by: David Gageot david@gageot.net