Catch a 409 when creating a bucket and continue.#1044
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Sep 27, 2018
Merged
Catch a 409 when creating a bucket and continue.#1044dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
dlorenc
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
==========================================
- Coverage 39.98% 39.91% -0.07%
==========================================
Files 70 70
Lines 3079 3084 +5
==========================================
Hits 1231 1231
- Misses 1721 1726 +5
Partials 127 127
Continue to review full report at Codecov.
|
dgageot
approved these changes
Sep 27, 2018
ahmetb
reviewed
Sep 27, 2018
| if e, ok := err.(*googleapi.Error); ok { | ||
| if e.Code == http.StatusConflict { | ||
| // 409 errors are ok, there could have been a race condition or eventual consistency. | ||
| logrus.Debugf("Not creating bucket, got a 409 error indicating it already exists.") |
Contributor
There was a problem hiding this comment.
I'd probably log the err here for diagnostics (i.e. in case some other 409 is returned in the future)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should fix #947