Simplify schema versioning#1067
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Oct 2, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
+ Coverage 41.22% 42.01% +0.78%
==========================================
Files 72 71 -1
Lines 3134 3187 +53
==========================================
+ Hits 1292 1339 +47
- Misses 1710 1715 +5
- Partials 132 133 +1
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
versionning
branch
3 times, most recently
from
8a15aaa to
12ab3ed
Compare
balopat
approved these changes
Oct 2, 2018
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
I really like the simplifications, thank you very much!
Signed-off-by: David Gageot <david@gageot.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to simplify the code as much as possible so that introducing new versions of the schema requires moving and copying fewer things around
Number of instances of
v1alphain the sources:find . -name .go -not -path "./vendor/" -exec cat {} ; | grep -c v1alpha
BEFORE: 143
AFTER: 21
Signed-off-by: David Gageot david@gageot.net