Implement a manual trigger for watch mode#1085
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Oct 4, 2018
Merged
Implement a manual trigger for watch mode#1085dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
dgageot
force-pushed
the
manual-watch-node
branch
from
171d545 to
d1634ba
Compare
balopat
approved these changes
Oct 4, 2018
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
little nit, otherwise LGTM
pkg/skaffold/watch/triggers.go
Outdated
| // Trigger describes a mechanism that triggers the watch. | ||
| type Trigger interface { | ||
| Start() (<-chan bool, func()) | ||
| WatchingForChanges(io.Writer) |
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
manual-watch-node
branch
from
d1634ba to
62b5ff6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
- Coverage 42.57% 42.43% -0.14%
==========================================
Files 71 72 +1
Lines 3239 3280 +41
==========================================
+ Hits 1379 1392 +13
- Misses 1727 1754 +27
- Partials 133 134 +1
Continue to review full report at Codecov.
|
Contributor
|
What if we had implemented manual triggering as a different watcher altogether? Since really its a I still think you always want both at the same time |
Contributor
Author
|
@r2d4 with current code, we could do both but I have no idea how that would work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One can now run
skaffold dev --trigger=manualto:The default trigger type is
polling. Another trigger type could expose a named pipe or socket to send refresh commands.Signed-off-by: David Gageot david@gageot.net