Add --label flag to specify custom labels for deployments#1098
Merged
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom Oct 4, 2018
Merged
Add --label flag to specify custom labels for deployments#1098priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
This should work for skaffold run, dev, and deploy. This is one of the features requested for integrating skaffold with IntelliJ. e.g. skaffold run --label firstlabel=one --label secondlabel=two
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1098 +/- ##
==========================================
+ Coverage 42.24% 42.32% +0.07%
==========================================
Files 72 72
Lines 3295 3303 +8
==========================================
+ Hits 1392 1398 +6
- Misses 1769 1771 +2
Partials 134 134
Continue to review full report at Codecov.
|
Contributor
|
ref #657 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should work for skaffold run, dev, and deploy to help support external tools/scripts provide their own labels.
e.g. skaffold run --label firstlabel=one --label secondlabel=two