Kaniko improvements#1101
Merged
dgageot merged 5 commits intoGoogleContainerTools:masterfrom Oct 5, 2018
Merged
Conversation
Contributor
dgageot
commented
Oct 5, 2018
dgageot
commented
- Add more logs to better debug when it goes weird
- Auto detect the bucket name from the image names if no bucket is provided
- Let the user override the kaniko image
- Upgrade kaniko to 0.4.0
- Simplify the code
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
kaniko-improvements
branch
from
7eeadf4 to
b0df629
Compare
Codecov Report
@@ Coverage Diff @@
## master #1101 +/- ##
=======================================
Coverage 43.16% 43.16%
=======================================
Files 74 74
Lines 3408 3408
=======================================
Hits 1471 1471
Misses 1799 1799
Partials 138 138
Continue to review full report at Codecov.
|
r2d4
approved these changes
Oct 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.