Node.js example with dependency handling and hot-reload

[mfornasa]

This is an implementation of the new file sync feature with Node.js.
It's more realistic than current one in hot-reload dir, as it features dependency handling with npm and package.json.

[codecov-io]

Codecov Report

Merging #1148 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1148   +/-   ##
=======================================
  Coverage   42.18%   42.18%           
=======================================
  Files          89       89           
  Lines        3999     3999           
=======================================
  Hits         1687     1687           
  Misses       2143     2143           
  Partials      169      169

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5382d...85ed343. Read the comment docs.

[r2d4]

Thanks! I’ll take a look soon

[r2d4]

LGTM. We don't have an integration test for this yet FYI, so I'll let another reviewer manually verify it.

[mfornasa]

*@dgageot Do you prefer an additional commit or a rebased one?*

…

On Fri, 12 Oct 2018 at 20:00, David Gageot ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In integration/examples/nodejs/README.adoc <#1148 (comment)> : > @@ -0,0 +1,16 @@ +=== Example: Node.js with hot-reload +:icons: font + +Simple example based on Node.js demonstating the file synchronization mode. s/demonstating/demonstrating ------------------------------ In integration/examples/nodejs/backend/Dockerfile <#1148 (comment)> : > @@ -0,0 +1,9 @@ +FROM node:8.12.0-alpine + +WORKDIR /opt/backend + +COPY . /opt/backend Can be COPY . . ------------------------------ In integration/examples/nodejs/backend/Dockerfile <#1148 (comment)> : > @@ -0,0 +1,9 @@ +FROM node:8.12.0-alpine + +WORKDIR /opt/backend + +COPY . /opt/backend +RUN npm install + +CMD ["npm", "run", "dev"] Can be moved up just after WORKDIR — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1148 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARG3YZWUnWFvJ97DJfTu6RdaSjrIZhPks5ukNjHgaJpZM4XZZBF> .

[dgageot]

As you see fit

[mfornasa]

@dgageot done