Use os.SameFile() to check for mvnw working-dir echo bug#1167
Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom Oct 15, 2018
Merged
Use os.SameFile() to check for mvnw working-dir echo bug#1167balopat merged 1 commit intoGoogleContainerTools:masterfrom
balopat merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
briandealwis
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1167 +/- ##
==========================================
- Coverage 42.19% 42.18% -0.01%
==========================================
Files 89 89
Lines 3996 3999 +3
==========================================
+ Hits 1686 1687 +1
- Misses 2142 2143 +1
- Partials 168 169 +1
Continue to review full report at Codecov.
|
coollog
approved these changes
Oct 15, 2018
balopat
approved these changes
Oct 15, 2018
Member
Author
|
Turns out the mvnw.cmd for Windows outputs |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative implementation to workaround the
mvnwbug described in #1155. Instead of canonicalizing each file to compare with the working directory, useos.SameFile()to compare theos.Stat()structures. Since we were obtaining the stat structures already, this should have minimal overhead.