Improve error handling for completion command#1206
Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom Oct 26, 2018
Merged
Improve error handling for completion command#1206balopat merged 1 commit intoGoogleContainerTools:masterfrom
completion command#1206balopat merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
We currently only support bash completion scripts, however as raised as part 1 of GoogleContainerTools#1012 this means we output bash completion script irrespective what the user types as the shell. This PR makes bash explicit, introduces valid args and checks for length and presence of valid args
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #1206 +/- ##
==========================================
- Coverage 41.45% 41.41% -0.04%
==========================================
Files 95 95
Lines 4229 4233 +4
==========================================
Hits 1753 1753
- Misses 2305 2309 +4
Partials 171 171
Continue to review full report at Codecov.
|
r2d4
approved these changes
Oct 26, 2018
balopat
approved these changes
Oct 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently only support bash completion scripts, however as raised as part (1) of #1012 this means we output bash completion script irrespective of what the user types as the shell.
This PR makes typing bash explicit and mandatory, introduces valid args and checks for length and presence of valid args