Automatically fix old configs by default#1259
Merged
nkubala merged 7 commits intoGoogleContainerTools:masterfrom Nov 14, 2018
Merged
Automatically fix old configs by default#1259nkubala merged 7 commits intoGoogleContainerTools:masterfrom
nkubala merged 7 commits intoGoogleContainerTools:masterfrom
Conversation
r2d4
reviewed
Nov 8, 2018
…latest semver to package level function
balopat
previously requested changes
Nov 12, 2018
Contributor
balopat
left a comment
There was a problem hiding this comment.
With this change I would like to cover all the upgrades with unit tests and hunt down if there are any issues.
Codecov Report
@@ Coverage Diff @@
## master #1259 +/- ##
==========================================
+ Coverage 42.42% 44.19% +1.76%
==========================================
Files 96 104 +8
Lines 4247 4614 +367
==========================================
+ Hits 1802 2039 +237
- Misses 2269 2366 +97
- Partials 176 209 +33
Continue to review full report at Codecov.
|
Added unit tests for all config upgrades
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a hook in the runner to automatically try and upgrade older configs to the latest version before running skaffold. This means users with older configs will no longer be required to run
skaffold fixto run skaffold as we upgrade the config.I'll leave
skaffold fixin, in case anybody wants to use it to upgrade their config and overwrite it in their repo.Fixes #1257