Allow passing arguments to bazel build#1289
Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom Nov 21, 2018
Merged
Allow passing arguments to bazel build#1289balopat merged 1 commit intoGoogleContainerTools:masterfrom
balopat merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
To make a container capable of being used by skaffold I need to be able to provide additional parameters on the command line. Add an args: element to the bazel build configuration that is a list of strings that will be passed to the build command.
Author
|
My specific requirement here is that I'm running bazel on OSX with a golang codebase. There are a couple of problems to do with the toolchain, gazelle, that don't resolve dependencies correctly when simply specify cross compile parameters. The advice from bazel is to pass "--platforms=@io_bazel_rules_go//go/toolchain:linux_amd64" to the build process. This will provide a way to set these parameters. |
Codecov Report
@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
- Coverage 44.24% 44.21% -0.03%
==========================================
Files 104 104
Lines 4629 4632 +3
==========================================
Hits 2048 2048
- Misses 2372 2375 +3
Partials 209 209
Continue to review full report at Codecov.
|
nkubala
approved these changes
Nov 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make a container capable of being used by skaffold I need to be able
to provide additional parameters on the command line. Add an args:
element to the bazel build configuration that is a list of strings that
will be passed to the build command.