Skip to content

The multi-deployer feature is not working. Remove it#1291

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:improve-runner-part01
Nov 20, 2018
Merged

The multi-deployer feature is not working. Remove it#1291
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:improve-runner-part01

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Nov 19, 2018

I'm trying to cut #1204 into pieces to make it easier to rebase and review.

This PR should, I think, be merged for the beta since it removes something that's not fully supported.

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 19, 2018

Codecov Report

Merging #1291 into master will increase coverage by 0.3%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1291     +/-   ##
=========================================
+ Coverage   44.24%   44.54%   +0.3%     
=========================================
  Files         104      103      -1     
  Lines        4629     4593     -36     
=========================================
- Hits         2048     2046      -2     
+ Misses       2372     2340     -32     
+ Partials      209      207      -2
Impacted Files Coverage Δ
pkg/skaffold/runner/runner.go 48.59% <50%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d808c...5aabf5f. Read the comment docs.

@dgageot dgageot changed the title The multi-deployer feature is not working The multi-deployer feature is not working. Remove it Nov 20, 2018
Copy link
Copy Markdown
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, LGTM

@balopat balopat merged commit 6cecdf8 into GoogleContainerTools:master Nov 20, 2018
@dgageot dgageot deleted the improve-runner-part01 branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants