Skip to content

Simplify the Runner's tests#1303

Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:simplify-runner-tests
Nov 21, 2018
Merged

Simplify the Runner's tests#1303
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:simplify-runner-tests

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Nov 21, 2018

Yet another extract of #1204

Simplify the Runner's tests.

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1303 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
+ Coverage   44.54%   44.71%   +0.17%     
==========================================
  Files         103      103              
  Lines        4598     4598              
==========================================
+ Hits         2048     2056       +8     
+ Misses       2343     2334       -9     
- Partials      207      208       +1
Impacted Files Coverage Δ
pkg/skaffold/runner/runner.go 49.39% <0%> (+0.8%) ⬆️
pkg/skaffold/runner/timings.go 30% <0%> (+15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2301db6...9851dbd. Read the comment docs.

@dgageot dgageot merged commit 70de84e into GoogleContainerTools:master Nov 21, 2018
@dgageot dgageot deleted the simplify-runner-tests branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants