Print logs for containers that are not ready#1344
Merged
nkubala merged 1 commit intoGoogleContainerTools:masterfrom Dec 1, 2018
Merged
Print logs for containers that are not ready#1344nkubala merged 1 commit intoGoogleContainerTools:masterfrom
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
+ Coverage 45.03% 45.05% +0.01%
==========================================
Files 114 114
Lines 4912 4910 -2
==========================================
Hits 2212 2212
+ Misses 2475 2473 -2
Partials 225 225
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
print-logs-even-if-not-ready
branch
2 times, most recently
from
61e06c4 to
9e7bf07
Compare
nkubala
reviewed
Nov 30, 2018
pkg/skaffold/kubernetes/log.go
Outdated
| continue | ||
| } | ||
|
|
||
| if alreadyTracked := a.trackedContainers.add(container.ContainerID); !alreadyTracked { |
Contributor
There was a problem hiding this comment.
can this not be if !a.trackedContainers.add(container.ContainerID)?
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
print-logs-even-if-not-ready
branch
from
9e7bf07 to
6339d13
Compare
Contributor
Author
|
@nkubala thanks for the feedback, should be good now! |
nkubala
approved these changes
Dec 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot david@gageot.net