Skip to content

Local builders return a digest#1374

Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:builders-return-digests
Dec 8, 2018
Merged

Local builders return a digest#1374
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:builders-return-digests

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Dec 7, 2018

Each builder is in charge of returning the digest of what it built.
digest is still digest|imageID though.

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot added the wip label Dec 7, 2018
Copy link
Copy Markdown
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 7, 2018

Codecov Report

Merging #1374 into master will increase coverage by 0.03%.
The diff coverage is 21.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
+ Coverage   44.88%   44.91%   +0.03%     
==========================================
  Files         114      114              
  Lines        4919     4909      -10     
==========================================
- Hits         2208     2205       -3     
+ Misses       2485     2481       -4     
+ Partials      226      223       -3
Impacted Files Coverage Δ
pkg/skaffold/build/local/jib_maven.go 38.59% <0%> (ø) ⬆️
pkg/skaffold/build/local/jib_gradle.go 21.87% <0%> (ø) ⬆️
pkg/skaffold/build/local/docker.go 21.05% <100%> (ø) ⬆️
pkg/skaffold/build/local/local.go 55.31% <100%> (+3.53%) ⬆️
pkg/skaffold/build/local/bazel.go 37.5% <25%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4043cea...018b70d. Read the comment docs.

@dgageot
Copy link
Copy Markdown
Contributor Author

dgageot commented Dec 7, 2018

@balopat Thank you, I put a wip label because I need to triple check if the Bazel builder still works

@dgageot dgageot removed the wip label Dec 8, 2018
@dgageot dgageot merged commit 9e3a40e into GoogleContainerTools:master Dec 8, 2018
@dgageot dgageot deleted the builders-return-digests branch December 28, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants