Omit empty strings in jib sections of the config#1399
Merged
nkubala merged 1 commit intoGoogleContainerTools:masterfrom Dec 18, 2018
Merged
Omit empty strings in jib sections of the config#1399nkubala merged 1 commit intoGoogleContainerTools:masterfrom
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Member
|
LGTM! |
dgageot
approved these changes
Dec 18, 2018
Codecov Report
@@ Coverage Diff @@
## master #1399 +/- ##
=======================================
Coverage 44.69% 44.69%
=======================================
Files 109 109
Lines 4546 4546
=======================================
Hits 2032 2032
Misses 2308 2308
Partials 206 206
Continue to review full report at Codecov.
|
r2d4
approved these changes
Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will prevent
skaffold fixfrom displaying these empty strings in the generated config.