Skip to content

Get digest on push and imageID on build#1428

Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot:digest-push-and-build
Dec 28, 2018
Merged

Get digest on push and imageID on build#1428
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot:digest-push-and-build

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Dec 27, 2018

This code tries to retrieve the digest/imageID immediately after the push/build.

Will enable a few simplifications in builders' code

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 27, 2018

Codecov Report

Merging #1428 into master will decrease coverage by 0.12%.
The diff coverage is 51.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
- Coverage   44.78%   44.66%   -0.13%     
==========================================
  Files         111      111              
  Lines        4551     4579      +28     
==========================================
+ Hits         2038     2045       +7     
- Misses       2308     2326      +18     
- Partials      205      208       +3
Impacted Files Coverage Δ
pkg/skaffold/build/local/local.go 54.34% <0%> (ø) ⬆️
pkg/skaffold/build/local/jib_maven.go 38.59% <0%> (ø) ⬆️
pkg/skaffold/build/local/bazel.go 37.5% <0%> (ø) ⬆️
pkg/skaffold/build/local/jib_gradle.go 21.87% <0%> (ø) ⬆️
pkg/skaffold/build/local/docker.go 17.64% <50%> (-3.41%) ⬇️
pkg/skaffold/docker/image.go 56.25% <57.5%> (-2.94%) ⬇️
pkg/skaffold/docker/auth.go 38.09% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a3404...25f5549. Read the comment docs.

@dgageot dgageot merged commit 2043aaf into GoogleContainerTools:master Dec 28, 2018
@dgageot dgageot deleted the digest-push-and-build branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants