Fix port-forwarding not being triggered.#1433
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Dec 31, 2018
Merged
Fix port-forwarding not being triggered.#1433dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Signed-off-by: Bruno Miguel Custodio <brunomcustodio@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1433 +/- ##
==========================================
- Coverage 44.56% 44.53% -0.03%
==========================================
Files 112 112
Lines 4593 4596 +3
==========================================
Hits 2047 2047
- Misses 2339 2342 +3
Partials 207 207
Continue to review full report at Codecov.
|
r2d4
approved these changes
Dec 29, 2018
Contributor
r2d4
left a comment
There was a problem hiding this comment.
Thanks - looks like I made a bad assumption
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running
skaffold devto deploy a pod containing some port definitions, I noticed that port-forwardings were not being triggered. Turns out this was happening because...ADDEDevents are currently ignored by the port forwarder's pod watcher; andRunningphase when the watcher is established; andMODIFIED) were received for that pod (so as to trigger forwarding).My proposal is that the port forwarder's pod watcher starts taking
ADDEDevents into account.