Clear error message for unsupported artifact on GCB#1453
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Jan 14, 2019
Merged
Clear error message for unsupported artifact on GCB#1453dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1453 +/- ##
==========================================
+ Coverage 44.19% 44.33% +0.14%
==========================================
Files 112 113 +1
Lines 4641 4660 +19
==========================================
+ Hits 2051 2066 +15
- Misses 2382 2386 +4
Partials 208 208
Continue to review full report at Codecov.
|
priyawadhwa
reviewed
Jan 11, 2019
Contributor
priyawadhwa
left a comment
priyawadhwa
left a comment
There was a problem hiding this comment.
LGTM, but did you mean to check in the debug.test file?
Contributor
Author
|
No, indeed. I’ll remove it. Thanks! |
Also prepare the support for other artifacts types Signed-off-by: David Gageot <david@gageot.net>
priyawadhwa
approved these changes
Jan 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also prepare the support for other artifacts types
Signed-off-by: David Gageot david@gageot.net