Simplify docker.AddTag()

[dgageot]

Fixes #1460

All credits goes to jonjohnson@google.com

Signed-off-by: David Gageot david@gageot.net

[codecov-io]

Codecov Report

Merging #1464 into master will increase coverage by 0.07%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1464      +/-   ##
==========================================
+ Coverage    44.8%   44.88%   +0.07%     
==========================================
  Files         112      112              
  Lines        4638     4630       -8     
==========================================
  Hits         2078     2078              
+ Misses       2350     2342       -8     
  Partials      210      210

Impacted Files	Coverage Δ
pkg/skaffold/docker/remote.go	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69776b1...c1265a9. Read the comment docs.

[jonjohnsonjr]

For anyone following along, I think this change is good (it's less code), but it looks like the bug is here:

skaffold/pkg/skaffold/build/local/local.go

Lines 94 to 99 in db5e1ad

	if b.pushImages && (artifact.JibMavenArtifact != nil || artifact.JibGradleArtifact != nil) {
	if err := docker.AddTag(initialTag, newTag); err != nil {
	return errors.Wrap(err, "tagging image")
	}
	return nil
	}