Skip to content

Remove some duplication in Jib builder#1465

Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:remove-jib-duplication
Jan 15, 2019
Merged

Remove some duplication in Jib builder#1465
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:remove-jib-duplication

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Jan 14, 2019

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 14, 2019

Codecov Report

Merging #1465 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
- Coverage   44.53%   44.43%   -0.11%     
==========================================
  Files         112      112              
  Lines        4650     4641       -9     
==========================================
- Hits         2071     2062       -9     
  Misses       2372     2372              
  Partials      207      207
Impacted Files Coverage Δ
pkg/skaffold/jib/jib_maven.go 100% <100%> (ø) ⬆️
pkg/skaffold/jib/jib_gradle.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db5e1ad...e2c3c0b. Read the comment docs.

@dgageot dgageot merged commit e3eb78f into GoogleContainerTools:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants