Use Maven wrapper for Jib example easier start.#1471
Use Maven wrapper for Jib example easier start.#1471dgageot merged 3 commits intoGoogleContainerTools:masterfrom ivanporty:master
Conversation
…t for port forwarding.
Codecov Report
@@ Coverage Diff @@
## master #1471 +/- ##
=======================================
Coverage 44.43% 44.43%
=======================================
Files 112 112
Lines 4641 4641
=======================================
Hits 2062 2062
Misses 2372 2372
Partials 207 207Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1471 +/- ##
=======================================
Coverage 44.43% 44.43%
=======================================
Files 112 112
Lines 4641 4641
=======================================
Hits 2062 2062
Misses 2372 2372
Partials 207 207Continue to review full report at Codecov.
|
coollog
left a comment
There was a problem hiding this comment.
Should we use version 3.6.0 since that is the latest?
|
Sure, good idea, I'll bump up the version. |
|
@ivanporty this is awesome. One issue, you have to also fix the same sample under |
|
Ah, good to know, let me make the changes there as well. |
|
@dgageot the integration example is updated as well, let me know if something else is missing, thanks! |
When working on coming IntelliJ IDE plugin demos, running Jib example is not as easy as it could be with a added Maven wrapper. Maven is required in
PATHfor example to work, but it may not be used at all (i.e. developer uses Gradle instead) or not used in CLI (internal IDE support for Maven). Maven wrapper will download and provide Maven automatically and Jib knows how to pick it up.Also, this PR exposes container port for port forwarding in the container section, without it
skaffolddoes not port-forward 8080 automatically.