Skip to content

Support secretGenerators with kustomize #1488

Merged
nkubala merged 2 commits intoGoogleContainerTools:masterfrom
dgageot:fix-1035
Jan 19, 2019
Merged

Support secretGenerators with kustomize #1488
nkubala merged 2 commits intoGoogleContainerTools:masterfrom
dgageot:fix-1035

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Jan 18, 2019

Fixes #1035

Fix GoogleContainerTools#1035

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 18, 2019

Codecov Report

Merging #1488 into master will increase coverage by 0.02%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1488      +/-   ##
==========================================
+ Coverage   44.82%   44.85%   +0.02%     
==========================================
  Files         115      115              
  Lines        4767     4769       +2     
==========================================
+ Hits         2137     2139       +2     
  Misses       2409     2409              
  Partials      221      221
Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl/version.go 0% <0%> (ø) ⬆️
pkg/skaffold/deploy/kubectl.go 52.12% <100%> (ø) ⬆️
pkg/skaffold/deploy/kustomize.go 34.61% <50%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec7dc3...37b455e. Read the comment docs.

@nkubala nkubala merged commit 4ec6b23 into GoogleContainerTools:master Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants