Fix onbuild analysis#1491
Conversation
Signed-off-by: David Gageot <david@gageot.net>
Codecov Report
@@ Coverage Diff @@
## master #1491 +/- ##
==========================================
+ Coverage 44.87% 45.04% +0.16%
==========================================
Files 115 115
Lines 4771 4771
==========================================
+ Hits 2141 2149 +8
+ Misses 2409 2397 -12
- Partials 221 225 +4
Continue to review full report at Codecov.
|
713309c to
dccc636
Compare
Fixes GoogleContainerTools#1496 Signed-off-by: David Gageot <david@gageot.net>
dccc636 to
9f4e83e
Compare
nkubala
left a comment
There was a problem hiding this comment.
Well, there it is....I said I would take responsibility if this broke something, so let it be known that this one is all my fault 🤦♂️
@dgageot thanks for fixing, though I'm still a bit unsure this is the right way to do this. We can address in another PR, but I think we might want to try using latest if we don't have an explicit tag. Otherwise this can return strange results w.r.t. the image registry (e.g. sometimes it will give you back index.docker.io in places you don't want it). I'll need to play around with it some more though, so for now this LGTM
Current code fails to retrieve remote image for
python:3-slim