Revert "Merge pull request #1439 from ltouati/fsnotify"#1508
Revert "Merge pull request #1439 from ltouati/fsnotify"#1508nkubala merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
|
There no way to remove the dependency on cgo. Let’s try to improve our release system for next release |
Codecov Report
@@ Coverage Diff @@
## master #1508 +/- ##
==========================================
+ Coverage 45% 45.27% +0.27%
==========================================
Files 115 115
Lines 4802 4764 -38
==========================================
- Hits 2161 2157 -4
+ Misses 2420 2387 -33
+ Partials 221 220 -1
Continue to review full report at Codecov.
|
|
I'm happy to work on this as Skaffold is not usable with large projects if you don't use notifications. Can you please point me to the relevant part ? Thx |
|
@ltouati thanks. unfortunately I think the responsibility lies with us, we need to come up with another CI solution that is able to build for all platforms because right now we rely on go cross compilation and this won't work with cgo. I'd like to see this go back in for the next release though, so we'll keep you posted. |
This reverts commit 3402a94, reversing
changes made to 3795677.
@ltouati unfortunately, this change requires cgo, which is incompatible with cross-compilation in Golang, effectively breaking our CI. This will need to be reworked to remove its dependency on cgo before it can go back in.