Skip to content

Add --build-image option to build command#1591

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
shuheiktgw:add_build_image_option
Feb 5, 2019
Merged

Add --build-image option to build command#1591
balopat merged 1 commit intoGoogleContainerTools:masterfrom
shuheiktgw:add_build_image_option

Conversation

@shuheiktgw
Copy link
Copy Markdown
Contributor

Hi, I tried solving the issue #1092, and added --build-image option to build command! Thanks! 👍

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 3, 2019

Codecov Report

Merging #1591 into master will decrease coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1591      +/-   ##
==========================================
- Coverage   46.51%   46.46%   -0.05%     
==========================================
  Files         118      118              
  Lines        5044     5049       +5     
==========================================
  Hits         2346     2346              
- Misses       2464     2469       +5     
  Partials      234      234
Impacted Files Coverage Δ
pkg/skaffold/config/options.go 88.23% <ø> (ø) ⬆️
pkg/skaffold/runner/dev.go 56.52% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/dev.go 0% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/build.go 0% <0%> (ø) ⬆️
pkg/skaffold/runner/filters.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5dbcb3...81a6ce1. Read the comment docs.

@balopat balopat added kokoro:run runs the kokoro jobs on a PR !! config-change !! labels Feb 5, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Feb 5, 2019
@balopat balopat merged commit 052be39 into GoogleContainerTools:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants