Extract yaml used in documentation into files#1593
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Feb 4, 2019
Merged
Extract yaml used in documentation into files#1593dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Signed-off-by: David Gageot <david@gageot.net>
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1593 +/- ##
=======================================
Coverage 46.51% 46.51%
=======================================
Files 118 118
Lines 5044 5044
=======================================
Hits 2346 2346
Misses 2464 2464
Partials 234 234Continue to review full report at Codecov.
|
balopat
approved these changes
Feb 4, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
LGTM, thanks, this is awesome!
The only tiny nit I have that as it is the readFile shortcode always adds a yaml syntaxed code.
We could rename it to includeYaml or maybe we can parametrize the language and add the yaml tag on readFile as a parameter...
Contributor
Author
|
@balopat Thanks! I'll add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a shortcode to embed yaml configuration fragments into the documentation.
The fragments are parsed by a unit test to ensure that each of them is a valid configuration.
This helped fix a bug in one of the yaml files.
Signed-off-by: David Gageot david@gageot.net