Remove Tagger from Builder interface#1601
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Feb 6, 2019
Merged
Remove Tagger from Builder interface#1601dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
dgageot
force-pushed
the
remove-tagger-from-builder-interface
branch
from
384aa1b to
ed84316
Compare
Codecov Report
@@ Coverage Diff @@
## master #1601 +/- ##
==========================================
+ Coverage 46.31% 47.01% +0.69%
==========================================
Files 117 117
Lines 5106 5118 +12
==========================================
+ Hits 2365 2406 +41
+ Misses 2508 2471 -37
- Partials 233 241 +8
Continue to review full report at Codecov.
|
nkubala
reviewed
Feb 5, 2019
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
so much cleaner 😍 a few nits but it looks great
| description string | ||
| api testutil.FakeAPIClient | ||
| tagger tag.Tagger | ||
| tagger tag.ByImage |
Contributor
There was a problem hiding this comment.
nit: I'd change this to tags instead of tagger
pkg/skaffold/build/prebuilt.go
Outdated
| } | ||
|
|
||
| func (b *prebuiltImagesBuilder) Build(ctx context.Context, out io.Writer, tagger tag.Tagger, artifacts []*latest.Artifact) ([]Artifact, error) { | ||
| func (b *prebuiltImagesBuilder) Build(ctx context.Context, out io.Writer, tagsIgnored tag.ByImage, artifacts []*latest.Artifact) ([]Artifact, error) { |
Contributor
There was a problem hiding this comment.
if these are actually unused then can we just pass them as _ tag.ByImage?
pkg/skaffold/build/tag/tag.go
Outdated
| package tag | ||
|
|
||
| // ByImage maps image names to tags | ||
| type ByImage map[string]string |
Contributor
There was a problem hiding this comment.
this name is slightly confusing to me, maybe it makes more sense as ImageTags or ImageToTag?
pkg/skaffold/runner/runner.go
Outdated
|
|
||
| // imageTags generates tags for a list of artifacts | ||
| func (r *SkaffoldRunner) imageTags(out io.Writer, artifacts []*latest.Artifact) (tag.ByImage, error) { | ||
| tags := make(tag.ByImage) |
Contributor
There was a problem hiding this comment.
tags := make(tag.ByImage, len(artifacts))?
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
remove-tagger-from-builder-interface
branch
from
ed84316 to
c6f2b7d
Compare
Contributor
Author
|
@nkubala @priyawadhwa Should be ready for review |
priyawadhwa
approved these changes
Feb 6, 2019
Contributor
priyawadhwa
left a comment
priyawadhwa
left a comment
There was a problem hiding this comment.
so hyped for this! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tags are now computed by the runner and passed as a
mapto the builder.This makes it easier to transform builder into plugins that have basically no notion of tagging