Skip to content

Add --color option#1618

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
shuheiktgw:add_color_option
Feb 12, 2019
Merged

Add --color option#1618
balopat merged 1 commit intoGoogleContainerTools:masterfrom
shuheiktgw:add_color_option

Conversation

@shuheiktgw
Copy link
Copy Markdown
Contributor

Tackled #1583! Thank you for your review! 👍

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1618 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1618      +/-   ##
==========================================
+ Coverage   47.01%   47.01%   +<.01%     
==========================================
  Files         117      117              
  Lines        5118     5122       +4     
==========================================
+ Hits         2406     2408       +2     
- Misses       2471     2473       +2     
  Partials      241      241
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 0% <0%> (ø) ⬆️
pkg/skaffold/color/formatter.go 75% <100%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7a22f...958a851. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 7, 2019

Codecov Report

Merging #1618 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1618      +/-   ##
==========================================
+ Coverage   47.01%   47.01%   +<.01%     
==========================================
  Files         117      117              
  Lines        5118     5122       +4     
==========================================
+ Hits         2406     2408       +2     
- Misses       2471     2473       +2     
  Partials      241      241
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 0% <0%> (ø) ⬆️
pkg/skaffold/color/formatter.go 75% <100%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7a22f...958a851. Read the comment docs.

Copy link
Copy Markdown
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shuheiktgw thanks for the fix!

I also wouldn't mind changing the default value outright as well, but we don't have to do that here.

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Feb 11, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Feb 11, 2019
@balopat balopat merged commit 1193ccf into GoogleContainerTools:master Feb 12, 2019
@shuheiktgw shuheiktgw deleted the add_color_option branch February 12, 2019 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants