Don't push all tags when sha256 builds just one#1634
Merged
dgageot merged 6 commits intoGoogleContainerTools:masterfrom Feb 10, 2019
Merged
Don't push all tags when sha256 builds just one#1634dgageot merged 6 commits intoGoogleContainerTools:masterfrom
dgageot merged 6 commits intoGoogleContainerTools:masterfrom
Conversation
3e7e1d7 to
7a14368
Compare
Codecov Report
@@ Coverage Diff @@
## master #1634 +/- ##
==========================================
+ Coverage 46.9% 46.95% +0.05%
==========================================
Files 119 119
Lines 5134 5139 +5
==========================================
+ Hits 2408 2413 +5
Misses 2478 2478
Partials 248 248
Continue to review full report at Codecov.
|
dgageot
suggested changes
Feb 9, 2019
Contributor
|
@michaelfig Could you create a ticket with a procedure to reproduce? I couldn't reproduce the issue here. |
Contributor
Author
|
@dgageot working on finding a simple example for a new issue. |
Contributor
Author
dgageot
approved these changes
Feb 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't yet know how to describe the problem, except for that sha256 sends thousands of pushes if you use it with an image that doesn't have its own tag.
Forcing the tag to
:skaffold(:latestwould work, too) makes it behave properly.