kubectl deployer: warn when pattern matches no file#1647
Merged
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom Feb 13, 2019
Merged
kubectl deployer: warn when pattern matches no file#1647priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
corneliusweig
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1647 +/- ##
==========================================
- Coverage 46.95% 46.93% -0.02%
==========================================
Files 119 119
Lines 5143 5145 +2
==========================================
Hits 2415 2415
- Misses 2480 2481 +1
- Partials 248 249 +1
Continue to review full report at Codecov.
|
dgageot
previously requested changes
Feb 13, 2019
Contributor
dgageot
left a comment
dgageot
left a comment
There was a problem hiding this comment.
@corneliusweig like @priyawadhwa said on the issue, we'd rather have a warning here.
…ools#1645) Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
corneliusweig
force-pushed
the
manifest-exists
branch
from
23a094b to
10a59a1
Compare
Contributor
Author
|
@dgageot sure. That comment was later than this PR :) |
corneliusweig
changed the title
priyawadhwa
approved these changes
Feb 13, 2019
Contributor
priyawadhwa
left a comment
priyawadhwa
left a comment
There was a problem hiding this comment.
Thanks for fixing this! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1645