Generate annotated-skaffold.yaml#1659
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Feb 20, 2019
Merged
Conversation
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1659 +/- ##
==========================================
+ Coverage 47.41% 47.46% +0.05%
==========================================
Files 122 122
Lines 5448 5454 +6
==========================================
+ Hits 2583 2589 +6
Misses 2604 2604
Partials 261 261
Continue to review full report at Codecov.
|
| // Sync lists local files that can be synced to remote pods (alpha) instead | ||
| // Sync (alpha) lists local files that can be synced to remote pods instead | ||
| // of triggering an image build when modified. | ||
| // This is a mapping of local files to sync to remote folders. |
Member
There was a problem hiding this comment.
I believe sync can now support ** too?
balopat
reviewed
Feb 19, 2019
pkg/skaffold/schema/latest/config.go
Outdated
| TagPolicy TagPolicy `yaml:"tagPolicy,omitempty"` | ||
|
|
||
| // ExecutionEnvironment is the environment in which the build | ||
| // should run (ex. local or in-cluster, etc.). |
Contributor
There was a problem hiding this comment.
Suggested change
| // should run (ex. local or in-cluster, etc.). | |
| // should run. Possible values: googleCloudBuild. |
balopat
approved these changes
Feb 19, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
I only have nits but we can merge this for now.
I'm also curious to see how we're going to merge this with the site. Any plans there?
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
generate-annotated-skaffold
branch
from
1c17df9 to
b4c5485
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generates an html version of the annotated-skaffold.yaml that's always in sync with the Got structs. Next step is to use this in the website generation.
Signed-off-by: David Gageot david@gageot.net