added default-repo to getting started#1672
added default-repo to getting started#1672dgageot merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
balopat
requested review from
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
balopat
added
the
docs-modifications
|
Please visit http://35.235.69.96:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
Codecov Report
@@ Coverage Diff @@
## master #1672 +/- ##
==========================================
+ Coverage 47.41% 48.34% +0.93%
==========================================
Files 122 122
Lines 5448 5558 +110
==========================================
+ Hits 2583 2687 +104
- Misses 2604 2607 +3
- Partials 261 264 +3
Continue to review full report at Codecov.
|
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
grammar nits, but otherwise LGTM and thanks for adding :)
|
|
||
| Run command `skaffold dev` to build and deploy your app continuously. You should | ||
| see some outputs similar to the following entries: | ||
| Run command `skaffold dev --default-repo <myrepo>` to build and deploy your app continuously. |
There was a problem hiding this comment.
can we remove the word command here? sentence is a bit awkward with it.
| Run command `skaffold dev` to build and deploy your app continuously. You should | ||
| see some outputs similar to the following entries: | ||
| Run command `skaffold dev --default-repo <myrepo>` to build and deploy your app continuously. | ||
| The `--default-repo` functionality enables to push images to your own repository instead of the default `gcr.io/k8s-skaffold` repo. |
There was a problem hiding this comment.
s/enables to push/enables pushing
|
|
||
| See the [Github Examples page](https://github.com/GoogleContainerTools/skaffold/tree/master/examples) for examples. | ||
|
|
||
| To run the examples, you either have to manually replace the image repositories in the examples from gcr.io/k8s-skaffold to yours or you can point skaffold to your default image repository in one of the four ways: |
There was a problem hiding this comment.
a little nitpicky: can this be structured something like:
To run the examples in the repo, you have two options:
1) manually replace the image repositories in the example skaffold.yamls from gcr.io/k8s-skaffold to your own person repository
2) point skaffold to your default image repository in one of the four ways:
....
this just makes it a bit more clear to the user why it's being done this way, and why the default-repo stuff even exists in the first place.
balopat
added
the
docs-modifications
|
Please visit http://35.235.74.87:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
6 participants
Fixes #1669.