Generate skaffold references#1675
Merged
dgageot merged 4 commits intoGoogleContainerTools:masterfrom Feb 21, 2019
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #1675 +/- ##
==========================================
+ Coverage 47.46% 47.48% +0.01%
==========================================
Files 122 122
Lines 5454 5456 +2
==========================================
+ Hits 2589 2591 +2
Misses 2604 2604
Partials 261 261
Continue to review full report at Codecov.
|
ddc1aa1 to
73157ee
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
9d59806 to
84bad63
Compare
This comment has been minimized.
This comment has been minimized.
84bad63 to
2d7439f
Compare
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
2d7439f to
34b12c5
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: David Gageot <david@gageot.net>
34b12c5 to
742aa9f
Compare
This comment has been minimized.
This comment has been minimized.
balopat
approved these changes
Feb 21, 2019
Contributor
balopat
left a comment
There was a problem hiding this comment.
This.is.so.cool.
thank you :)
Contributor
|
Follow-up thoughts for next iterations (we don't have to do it in this PR, but we have to do it before the release)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.