Add example of a Jib-Maven multi-module project#1676
Merged
dgageot merged 3 commits intoGoogleContainerTools:masterfrom Feb 21, 2019
Merged
Add example of a Jib-Maven multi-module project#1676dgageot merged 3 commits intoGoogleContainerTools:masterfrom
dgageot merged 3 commits intoGoogleContainerTools:masterfrom
Conversation
briandealwis
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1676 +/- ##
=======================================
Coverage 47.46% 47.46%
=======================================
Files 122 122
Lines 5454 5454
=======================================
Hits 2589 2589
Misses 2604 2604
Partials 261 261Continue to review full report at Codecov.
|
dgageot
suggested changes
Feb 20, 2019
Contributor
dgageot
left a comment
dgageot
left a comment
There was a problem hiding this comment.
LGTM but the examples must be copied in integration/examples too
balopat
reviewed
Feb 20, 2019
Co-Authored-By: briandealwis <bsd@mt.ca>
Member
Author
|
PTAL — copied into |
dgageot
approved these changes
Feb 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #1299
PTAL @dgageot